config.c

Go to the documentation of this file.

 
#include <ascii-chat/options/config.h>
#include <ascii-chat/common/error_codes.h>
#include <ascii-chat/options/options.h>
#include <ascii-chat/options/validation.h>
#include <ascii-chat/options/schema.h>
#include <ascii-chat/options/rcu.h>
#include <ascii-chat/util/path.h>
#include <ascii-chat/util/utf8.h>
#include <ascii-chat/common.h>
#include <ascii-chat/platform/terminal.h>
#include <ascii-chat/platform/system.h>
#include <ascii-chat/platform/question.h>
#include <ascii-chat/platform/stat.h>
#include <ascii-chat/platform/filesystem.h>
#include <ascii-chat/crypto/crypto.h>
#include <ascii-chat/log/logging.h>
#include <ascii-chat/video/palette.h>
#include <ascii-chat/video/color_filter.h>
#include <ascii-chat/version.h>
#include <ascii-chat/tooling/defer/defer.h>
 
#include <ascii-chat-deps/tomlc17/src/tomlc17.h>
#include <string.h>
#include <stdlib.h>
#include <stdio.h>
#include <errno.h>
#include <sys/stat.h>
 
#define CONFIG_WARN(fmt, ...)                                                                                          \
  do {                                                                                                                 \
    log_warn("Config file: " fmt, ##__VA_ARGS__);                                                                      \
  } while (0)
 
#define CONFIG_DEBUG(fmt, ...)                                                                                         \
  do {                                                                                                                 \
    /* Debug messages are only shown in debug builds after logging is initialized */                                   \
    /* Use log_debug which safely checks initialization itself */                                                      \
    log_debug(fmt, ##__VA_ARGS__);                                                                                     \
  } while (0)
 
// Configuration state tracking removed - not needed with schema-driven approach
// CLI arguments always override config values, so no need to track what was set
 
/* Validation functions are now provided by options/validation.h */
 
static const char *get_toml_string_validated(toml_datum_t datum) {
  if (datum.type != TOML_STRING) {
    SET_ERRNO(ERROR_INVALID_PARAM, "not a toml string");
    return NULL;
  }
 
  const char *str = datum.u.s;
  if (!str) {
    SET_ERRNO(ERROR_INVALID_PARAM, "no toml string");
    return NULL;
  }
 
  // Validate UTF-8 encoding using utility function
  if (!utf8_is_valid(str)) {
    log_warn("Config value contains invalid UTF-8 sequence");
    return NULL;
  }
 
  return str;
}
 
// ============================================================================
// Type Handler Registry - Consolidates 4 duplicated switch statements
// ============================================================================
// TECHNICAL DEBT FIX: The code previously had 4 separate switch(meta->type)
// blocks for extract, parse, write, and format operations. This consolidated
// registry eliminates ~300 lines of code duplication while maintaining all
// type-specific logic and special case handling.
 
typedef union {
  char str_value[OPTIONS_BUFF_SIZE]; // STRING type
  int int_value;                     // INT type
  bool bool_value;                   // BOOL type
  float float_value;                 // DOUBLE type (float variant)
  double double_value;               // DOUBLE type (double variant)
} option_parsed_value_t;
 
typedef struct {
  void (*extract)(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                  bool *has_value); 
  asciichat_error_t (*parse_validate)(const char *value_str, const config_option_metadata_t *meta,
                                      option_parsed_value_t *parsed, char *error_msg,
                                      size_t error_size); 
  asciichat_error_t (*write_to_struct)(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                       options_t *opts, char *error_msg,
                                       size_t error_size); 
  void (*format_output)(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                        size_t bufsize); 
} option_type_handler_t;
 
// Forward declarations
static void extract_string(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                           bool *has_value);
static void extract_int(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                        bool *has_value);
static void extract_bool(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                         bool *has_value);
static void extract_double(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                           bool *has_value);
static asciichat_error_t parse_validate_string(const char *value_str, const config_option_metadata_t *meta,
                                               option_parsed_value_t *parsed, char *error_msg, size_t error_size);
static asciichat_error_t parse_validate_int(const char *value_str, const config_option_metadata_t *meta,
                                            option_parsed_value_t *parsed, char *error_msg, size_t error_size);
static asciichat_error_t parse_validate_bool(const char *value_str, const config_option_metadata_t *meta,
                                             option_parsed_value_t *parsed, char *error_msg, size_t error_size);
static asciichat_error_t parse_validate_double(const char *value_str, const config_option_metadata_t *meta,
                                               option_parsed_value_t *parsed, char *error_msg, size_t error_size);
static asciichat_error_t write_string(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                      options_t *opts, char *error_msg, size_t error_size);
static asciichat_error_t write_int(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                   options_t *opts, char *error_msg, size_t error_size);
static asciichat_error_t write_bool(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                    options_t *opts, char *error_msg, size_t error_size);
static asciichat_error_t write_double(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                      options_t *opts, char *error_msg, size_t error_size);
static void format_string(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                          size_t bufsize);
static void format_int(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                       size_t bufsize);
static void format_bool(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                        size_t bufsize);
static void format_double(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                          size_t bufsize);
static void format_callback(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                            size_t bufsize);
 
// Handler registry - indexed by option_type_t
static const option_type_handler_t g_type_handlers[] = {
    [OPTION_TYPE_STRING] = {extract_string, parse_validate_string, write_string, format_string},
    [OPTION_TYPE_INT] = {extract_int, parse_validate_int, write_int, format_int},
    [OPTION_TYPE_BOOL] = {extract_bool, parse_validate_bool, write_bool, format_bool},
    [OPTION_TYPE_DOUBLE] = {extract_double, parse_validate_double, write_double, format_double},
    [OPTION_TYPE_CALLBACK] = {NULL, NULL, NULL, format_callback},
    [OPTION_TYPE_ACTION] = {NULL, NULL, NULL, NULL},
};
 
// ============================================================================
// Type Handler Implementations
// ============================================================================
 
static void extract_string(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                           bool *has_value) {
  (void)int_val;
  (void)bool_val;
  (void)double_val;
 
  if (datum.type == TOML_STRING) {
    const char *str = get_toml_string_validated(datum);
    if (str && strlen(str) > 0) {
      SAFE_STRNCPY(value_str, str, BUFFER_SIZE_MEDIUM);
      *has_value = true;
    }
  } else if (datum.type == TOML_INT64) {
    // Convert integer to string (e.g., port = 7777)
    SAFE_SNPRINTF(value_str, BUFFER_SIZE_MEDIUM, "%lld", (long long)datum.u.int64);
    *has_value = true;
  }
}
 
static void extract_int(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                        bool *has_value) {
  (void)bool_val;
  (void)double_val;
 
  if (datum.type == TOML_INT64) {
    *int_val = (int)datum.u.int64;
    SAFE_SNPRINTF(value_str, BUFFER_SIZE_MEDIUM, "%d", *int_val);
    *has_value = true;
  } else if (datum.type == TOML_STRING) {
    const char *str = get_toml_string_validated(datum);
    if (str) {
      SAFE_STRNCPY(value_str, str, BUFFER_SIZE_MEDIUM);
      *has_value = true;
    }
  }
}
 
static void extract_bool(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                         bool *has_value) {
  (void)int_val;
  (void)double_val;
 
  if (datum.type == TOML_BOOLEAN) {
    *bool_val = datum.u.boolean;
    // Also set value_str for parse_validate phase
    SAFE_STRNCPY(value_str, *bool_val ? "true" : "false", BUFFER_SIZE_MEDIUM);
    *has_value = true;
  }
}
 
static void extract_double(toml_datum_t datum, char *value_str, int *int_val, bool *bool_val, double *double_val,
                           bool *has_value) {
  (void)int_val;
  (void)bool_val;
 
  if (datum.type == TOML_FP64) {
    *double_val = datum.u.fp64;
    SAFE_SNPRINTF(value_str, BUFFER_SIZE_MEDIUM, "%.10g", *double_val);
    *has_value = true;
  } else if (datum.type == TOML_STRING) {
    const char *str = get_toml_string_validated(datum);
    if (str) {
      SAFE_STRNCPY(value_str, str, BUFFER_SIZE_MEDIUM);
      *has_value = true;
    }
  }
}
 
static asciichat_error_t parse_validate_string(const char *value_str, const config_option_metadata_t *meta,
                                               option_parsed_value_t *parsed, char *error_msg, size_t error_size) {
  (void)meta;
  (void)error_msg;
  (void)error_size;
 
  SAFE_STRNCPY(parsed->str_value, value_str, sizeof(parsed->str_value));
  return ASCIICHAT_OK;
}
 
static asciichat_error_t parse_validate_int(const char *value_str, const config_option_metadata_t *meta,
                                            option_parsed_value_t *parsed, char *error_msg, size_t error_size) {
  // Detect enum fields by checking field_offset
  int enum_val = -1;
  bool is_enum = false;
 
  if (meta->field_offset == offsetof(options_t, color_mode)) {
    enum_val = validate_opt_color_mode(value_str, error_msg, error_size);
    is_enum = true;
  } else if (meta->field_offset == offsetof(options_t, color_filter)) {
    color_filter_t filter = color_filter_from_cli_name(value_str);
    if (filter != COLOR_FILTER_NONE || strcmp(value_str, "none") == 0) {
      enum_val = (int)filter;
    } else {
      SAFE_SNPRINTF(error_msg, error_size, "Invalid color filter '%s'", value_str);
      enum_val = -1;
    }
    is_enum = true;
  } else if (meta->field_offset == offsetof(options_t, render_mode)) {
    enum_val = validate_opt_render_mode(value_str, error_msg, error_size);
    is_enum = true;
  } else if (meta->field_offset == offsetof(options_t, palette_type)) {
    enum_val = validate_opt_palette(value_str, error_msg, error_size);
    is_enum = true;
  }
 
  if (is_enum) {
    // Enum parsing
    if (enum_val < 0) {
      // Backward compatibility: accept numeric enum values too.
      char *endptr = NULL;
      long raw_enum = strtol(value_str, &endptr, 10);
      bool parsed_numeric = (value_str && *value_str != '\0' && endptr && *endptr == '\0');
      bool numeric_valid = false;
 
      if (parsed_numeric && raw_enum >= INT_MIN && raw_enum <= INT_MAX) {
        int enum_int = (int)raw_enum;
        if (meta->field_offset == offsetof(options_t, color_mode)) {
          numeric_valid =
              (enum_int == COLOR_MODE_AUTO || enum_int == COLOR_MODE_NONE || enum_int == COLOR_MODE_16_COLOR ||
               enum_int == COLOR_MODE_256_COLOR || enum_int == COLOR_MODE_TRUECOLOR);
        } else if (meta->field_offset == offsetof(options_t, color_filter)) {
          numeric_valid = (enum_int >= COLOR_FILTER_NONE && enum_int < COLOR_FILTER_COUNT);
        } else if (meta->field_offset == offsetof(options_t, render_mode)) {
          numeric_valid = (enum_int == RENDER_MODE_FOREGROUND || enum_int == RENDER_MODE_BACKGROUND ||
                           enum_int == RENDER_MODE_HALF_BLOCK);
        } else if (meta->field_offset == offsetof(options_t, palette_type)) {
          numeric_valid = (enum_int >= PALETTE_STANDARD && enum_int < PALETTE_COUNT);
        }
        if (numeric_valid) {
          enum_val = enum_int;
        }
      }
 
      if (enum_val < 0) {
        if (strlen(error_msg) == 0) {
          SAFE_SNPRINTF(error_msg, error_size, "Invalid enum value: %s", value_str);
        }
        return ERROR_CONFIG;
      }
    }
    parsed->int_value = enum_val;
  } else {
    // Regular integer parsing
    char *endptr = NULL;
    long parsed_val = strtol(value_str, &endptr, 10);
    if (*endptr != '\0') {
      SAFE_SNPRINTF(error_msg, error_size, "Invalid integer: %s", value_str);
      return ERROR_CONFIG;
    }
    if (parsed_val < INT_MIN || parsed_val > INT_MAX) {
      SAFE_SNPRINTF(error_msg, error_size, "Integer out of range: %s", value_str);
      return ERROR_CONFIG;
    }
 
    int int_val = (int)parsed_val;
 
    // Check numeric range constraints if defined
    // Constraints are present if max != 0 (max will always be non-zero for bounded integer ranges)
    if (meta && meta->constraints.int_range.max != 0) {
      // Allow 0 as special "use default" value for certain fields
      bool is_auto_detect_field =
          (meta->field_offset == offsetof(options_t, width) || meta->field_offset == offsetof(options_t, height) ||
           meta->field_offset == offsetof(options_t, fps) ||
           meta->field_offset == offsetof(options_t, compression_level));
 
      if (int_val == 0 && is_auto_detect_field) {
        // 0 is allowed for these fields (means auto-detect or use default)
      } else if (int_val < meta->constraints.int_range.min || int_val > meta->constraints.int_range.max) {
        SAFE_SNPRINTF(error_msg, error_size, "Integer %d out of range [%d-%d]: %s", int_val,
                      meta->constraints.int_range.min, meta->constraints.int_range.max, value_str);
        return ERROR_CONFIG;
      }
    }
 
    parsed->int_value = int_val;
  }
  return ASCIICHAT_OK;
}
 
static asciichat_error_t parse_validate_bool(const char *value_str, const config_option_metadata_t *meta,
                                             option_parsed_value_t *parsed, char *error_msg, size_t error_size) {
  (void)meta;
  (void)error_msg;
  (void)error_size;
 
  // Parse boolean from string representation ("true" or "false")
  if (value_str && (strcmp(value_str, "true") == 0 || strcmp(value_str, "1") == 0 || strcmp(value_str, "yes") == 0)) {
    parsed->bool_value = true;
  } else {
    parsed->bool_value = false;
  }
  return ASCIICHAT_OK;
}
 
static asciichat_error_t parse_validate_double(const char *value_str, const config_option_metadata_t *meta,
                                               option_parsed_value_t *parsed, char *error_msg, size_t error_size) {
  char *endptr = NULL;
  double parsed_val = strtod(value_str, &endptr);
  if (*endptr != '\0') {
    SAFE_SNPRINTF(error_msg, error_size, "Invalid float: %s", value_str);
    return ERROR_CONFIG;
  }
 
  // Check numeric range constraints if defined (for double types)
  if (meta && meta->constraints.int_range.max != 0) {
    // Use int_range for doubles too (the values are stored as doubles in the constraint)
    double min = (double)meta->constraints.int_range.min;
    double max = (double)meta->constraints.int_range.max;
    if (parsed_val < min || parsed_val > max) {
      SAFE_SNPRINTF(error_msg, error_size, "Float %.2f out of range [%.2f-%.2f]: %s", parsed_val, min, max, value_str);
      return ERROR_CONFIG;
    }
  }
 
  parsed->float_value = (float)parsed_val;
  return ASCIICHAT_OK;
}
 
static asciichat_error_t write_string(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                      options_t *opts, char *error_msg, size_t error_size) {
  (void)error_msg;
  (void)error_size;
 
  char *field_ptr = ((char *)opts) + meta->field_offset;
  const char *final_value = parsed->str_value;
 
  // Special handling for path-based options (keys, log files)
  bool is_path_option = (strstr(meta->toml_key, "key") != NULL || strstr(meta->toml_key, "log_file") != NULL ||
                         strstr(meta->toml_key, "keyfile") != NULL);
  if (is_path_option) {
    // Check if it's a path that needs normalization
    if (path_looks_like_path(final_value)) {
      char *normalized = NULL;
      path_role_t role = PATH_ROLE_CONFIG_FILE; // Default
      if (strstr(meta->toml_key, "key") != NULL) {
        role = (strstr(meta->toml_key, "server_key") != NULL || strstr(meta->toml_key, "client_keys") != NULL)
                   ? PATH_ROLE_KEY_PUBLIC
                   : PATH_ROLE_KEY_PRIVATE;
      } else if (strstr(meta->toml_key, "log_file") != NULL) {
        role = PATH_ROLE_LOG_FILE;
      }
 
      asciichat_error_t path_result = path_validate_user_path(final_value, role, &normalized);
      if (path_result != ASCIICHAT_OK) {
        SAFE_FREE(normalized);
        return path_result;
      }
      SAFE_STRNCPY(field_ptr, normalized, meta->field_size);
      SAFE_FREE(normalized);
    } else {
      // Not a path, just an identifier (e.g., "gpg:keyid", "github:user")
      SAFE_STRNCPY(field_ptr, final_value, meta->field_size);
    }
 
    // Auto-enable encryption for crypto.key, crypto.password, crypto.keyfile
    if (strstr(meta->toml_key, "crypto.key") != NULL || strstr(meta->toml_key, "crypto.password") != NULL ||
        strstr(meta->toml_key, "crypto.keyfile") != NULL) {
      opts->encrypt_enabled = 1;
    }
  } else {
    SAFE_STRNCPY(field_ptr, final_value, meta->field_size);
  }
 
  return ASCIICHAT_OK;
}
 
static asciichat_error_t write_int(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                   options_t *opts, char *error_msg, size_t error_size) {
  (void)error_msg;
  (void)error_size;
 
  char *field_ptr = ((char *)opts) + meta->field_offset;
 
  // Handle unsigned short int fields (webcam_index)
  if (meta->field_size == sizeof(unsigned short int)) {
    *(unsigned short int *)field_ptr = (unsigned short int)parsed->int_value;
  } else {
    *(int *)field_ptr = parsed->int_value;
  }
 
  return ASCIICHAT_OK;
}
 
static asciichat_error_t write_bool(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                    options_t *opts, char *error_msg, size_t error_size) {
  (void)error_msg;
  (void)error_size;
 
  char *field_ptr = ((char *)opts) + meta->field_offset;
  bool bool_value = parsed->bool_value;
  bool is_inverted_no_splash = false;
  if (meta && meta->field_offset == offsetof(options_t, splash) && meta->toml_key) {
    const char *key = meta->toml_key;
    size_t key_len = strlen(key);
    static const char suffix[] = ".no_splash";
    size_t suffix_len = sizeof(suffix) - 1;
    is_inverted_no_splash = (key_len >= suffix_len && strcmp(key + (key_len - suffix_len), suffix) == 0);
  }
  if (is_inverted_no_splash) {
    bool_value = !bool_value;
  }
 
  // Handle unsigned short int bool fields (common in options_t)
  if (meta->field_size == sizeof(unsigned short int)) {
    *(unsigned short int *)field_ptr = bool_value ? 1 : 0;
  } else {
    *(bool *)field_ptr = bool_value;
  }
 
  return ASCIICHAT_OK;
}
 
static asciichat_error_t write_double(const option_parsed_value_t *parsed, const config_option_metadata_t *meta,
                                      options_t *opts, char *error_msg, size_t error_size) {
  (void)error_msg;
  (void)error_size;
 
  char *field_ptr = ((char *)opts) + meta->field_offset;
 
  // Check field_size to distinguish float from double
  // Use memcpy for alignment-safe writes
  if (meta->field_size == sizeof(float)) {
    float float_val = (float)parsed->float_value;
    memcpy(field_ptr, &float_val, sizeof(float));
  } else {
    double double_val = (double)parsed->float_value;
    memcpy(field_ptr, &double_val, sizeof(double));
  }
 
  return ASCIICHAT_OK;
}
 
static void format_string(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                          size_t bufsize) {
  (void)field_size;
  (void)meta;
 
  const char *str_value = (const char *)field_ptr;
  if (str_value && strlen(str_value) > 0) {
    char escaped_str[BUFFER_SIZE_MEDIUM * 2]; // Max 2x size for escaping '%'
    size_t j = 0;
    for (size_t i = 0; i < strlen(str_value) && j < sizeof(escaped_str) - 2; ++i) {
      if (str_value[i] == '%') {
        escaped_str[j++] = '%';
        escaped_str[j++] = '%';
      } else {
        escaped_str[j++] = str_value[i];
      }
    }
    escaped_str[j] = '\0';
 
    SAFE_SNPRINTF(buf, bufsize, "\"%s\"", escaped_str);
  } else {
    SAFE_SNPRINTF(buf, bufsize, "\"\"");
  }
}
 
static void format_int(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                       size_t bufsize) {
  int int_value = 0;
  if (field_size == sizeof(unsigned short int)) {
    int_value = *(unsigned short int *)field_ptr;
  } else {
    int_value = *(int *)field_ptr;
  }
 
  // Emit symbolic names for enum-backed values in generated config.
  if (meta && meta->field_offset == offsetof(options_t, color_mode)) {
    const char *name = "auto";
    if (int_value == COLOR_MODE_NONE) {
      name = "none";
    } else if (int_value == COLOR_MODE_16_COLOR) {
      name = "16";
    } else if (int_value == COLOR_MODE_256_COLOR) {
      name = "256";
    } else if (int_value == COLOR_MODE_TRUECOLOR) {
      name = "truecolor";
    }
    SAFE_SNPRINTF(buf, bufsize, "\"%s\"", name);
    return;
  }
 
  if (meta && meta->field_offset == offsetof(options_t, color_filter)) {
    const char *name = "none";
    if (int_value > COLOR_FILTER_NONE && int_value < COLOR_FILTER_COUNT) {
      const color_filter_def_t *def = color_filter_get_metadata((color_filter_t)int_value);
      if (def && def->cli_name) {
        name = def->cli_name;
      }
    }
    SAFE_SNPRINTF(buf, bufsize, "\"%s\"", name);
    return;
  }
 
  if (meta && meta->field_offset == offsetof(options_t, render_mode)) {
    const char *name = "foreground";
    if (int_value == RENDER_MODE_BACKGROUND) {
      name = "background";
    } else if (int_value == RENDER_MODE_HALF_BLOCK) {
      name = "half-block";
    }
    SAFE_SNPRINTF(buf, bufsize, "\"%s\"", name);
    return;
  }
 
  SAFE_SNPRINTF(buf, bufsize, "%d", int_value);
}
 
static void format_bool(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                        size_t bufsize) {
  bool bool_value = false;
  if (field_size == sizeof(unsigned short int)) {
    bool_value = *(unsigned short int *)field_ptr != 0;
  } else {
    bool_value = *(bool *)field_ptr;
  }
  bool is_inverted_no_splash = false;
  if (meta && meta->field_offset == offsetof(options_t, splash) && meta->toml_key) {
    const char *key = meta->toml_key;
    size_t key_len = strlen(key);
    static const char suffix[] = ".no_splash";
    size_t suffix_len = sizeof(suffix) - 1;
    is_inverted_no_splash = (key_len >= suffix_len && strcmp(key + (key_len - suffix_len), suffix) == 0);
  }
  if (is_inverted_no_splash) {
    bool_value = !bool_value;
  }
  SAFE_SNPRINTF(buf, bufsize, "%s", bool_value ? "true" : "false");
}
 
static void format_double(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                          size_t bufsize) {
  (void)meta;
 
  if (field_size == sizeof(float)) {
    float float_value = 0.0f;
    memcpy(&float_value, field_ptr, sizeof(float));
    SAFE_SNPRINTF(buf, bufsize, "%.1f", (double)float_value);
  } else {
    double double_value = 0.0;
    memcpy(&double_value, field_ptr, sizeof(double));
    SAFE_SNPRINTF(buf, bufsize, "%.1f", double_value);
  }
}
 
static void format_callback(const char *field_ptr, size_t field_size, const config_option_metadata_t *meta, char *buf,
                            size_t bufsize) {
  if (!field_ptr || !buf || !meta) {
    return;
  }
 
  if (meta->field_offset == offsetof(options_t, log_file) ||
      meta->field_offset == offsetof(options_t, palette_custom) ||
      meta->field_offset == offsetof(options_t, yt_dlp_options)) {
    format_string(field_ptr, field_size, meta, buf, bufsize);
    return;
  }
 
  if (meta->field_offset == offsetof(options_t, media_seek_timestamp) ||
      meta->field_offset == offsetof(options_t, microphone_sensitivity) ||
      meta->field_offset == offsetof(options_t, speakers_volume)) {
    format_double(field_ptr, field_size, meta, buf, bufsize);
    return;
  }
 
  if (field_size == sizeof(bool)) {
    format_bool(field_ptr, field_size, meta, buf, bufsize);
    return;
  }
 
  format_int(field_ptr, field_size, meta, buf, bufsize);
}
 
static asciichat_error_t config_apply_schema(toml_datum_t toptab, asciichat_mode_t detected_mode, options_t *opts,
                                             bool strict) {
  size_t metadata_count = 0;
  const config_option_metadata_t *metadata = config_schema_get_all(&metadata_count);
  asciichat_error_t first_error = ASCIICHAT_OK;
 
  // Track which options were set to avoid duplicates (e.g., log_file vs logging.log_file)
  size_t flags_count = metadata_count > 0 ? metadata_count : 1;
  bool *option_set_flags = SAFE_CALLOC(flags_count, sizeof(bool), bool *);
  if (!option_set_flags) {
    asciichat_error_t err = SET_ERRNO(ERROR_MEMORY, "Failed to allocate config option flags");
    return err;
  }
  defer(SAFE_FREE(option_set_flags));
 
  for (size_t i = 0; i < metadata_count; i++) {
    const config_option_metadata_t *meta = &metadata[i];
 
    // Validate mode compatibility using mode_bitmask
    // If mode_bitmask is 0 or BINARY, option applies to all modes
    if (meta->mode_bitmask != 0 && !(meta->mode_bitmask & OPTION_MODE_BINARY)) {
      // Option has specific mode restrictions - check if current mode matches
      bool applies_to_mode = false;
      if (detected_mode >= 0 && detected_mode <= MODE_DISCOVERY) {
        option_mode_bitmask_t mode_bit = (1 << detected_mode);
        applies_to_mode = (meta->mode_bitmask & mode_bit) != 0;
      }
 
      if (!applies_to_mode) {
        log_debug("Config: Option '%s' is not supported for this mode (skipping)", meta->toml_key);
        if (strict) {
          SAFE_FREE(option_set_flags);
          return SET_ERRNO(ERROR_CONFIG, "Option '%s' is not supported for this mode", meta->toml_key);
        }
        continue;
      }
    }
 
    // Skip if already set (avoid processing duplicates like log_file vs logging.log_file)
    if (option_set_flags[i]) {
      continue;
    }
 
    // Look up TOML value
    toml_datum_t datum = toml_seek(toptab, meta->toml_key);
    if (datum.type == TOML_UNKNOWN) {
      continue; // Option not present in config
    }
 
    // Extract value based on type using handler
    char value_str[BUFFER_SIZE_MEDIUM] = {0};
    bool has_value = false;
    int int_val = 0;
    bool bool_val = false;
    double double_val = 0.0;
 
    // Use type handler for extraction (consolidated from 5 switch cases)
    // For CALLBACK types, extract manually since they don't have extract handlers
    if (meta->type == OPTION_TYPE_CALLBACK) {
      if (datum.type == TOML_STRING) {
        const char *str = get_toml_string_validated(datum);
        if (str && strlen(str) > 0) {
          SAFE_STRNCPY(value_str, str, BUFFER_SIZE_MEDIUM);
          has_value = true;
        }
      } else if (datum.type == TOML_INT64) {
        // Convert integer to string (e.g., port = 8080)
        SAFE_SNPRINTF(value_str, BUFFER_SIZE_MEDIUM, "%lld", (long long)datum.u.int64);
        has_value = true;
      }
    } else if (g_type_handlers[meta->type].extract) {
      g_type_handlers[meta->type].extract(datum, value_str, &int_val, &bool_val, &double_val, &has_value);
    }
 
    if (!has_value) {
      continue;
    }
 
    // Special handling for palette-chars (auto-sets palette_type to CUSTOM)
    // The TOML key is "display.palette_chars" (from DISPLAY group, palette-chars option)
    if (strcmp(meta->toml_key, "display.palette_chars") == 0) {
      const char *chars_str = get_toml_string_validated(datum);
      if (chars_str && strlen(chars_str) > 0) {
        if (strlen(chars_str) < sizeof(opts->palette_custom)) {
          SAFE_STRNCPY(opts->palette_custom, chars_str, sizeof(opts->palette_custom));
          opts->palette_custom[sizeof(opts->palette_custom) - 1] = '\0';
          opts->palette_custom_set = true;
          opts->palette_type = PALETTE_CUSTOM;
          option_set_flags[i] = true;
        } else {
          CONFIG_WARN("Invalid palette.chars: too long (%zu chars, max %zu, skipping)", strlen(chars_str),
                      sizeof(opts->palette_custom) - 1);
          if (strict) {
            SAFE_FREE(option_set_flags);
            return SET_ERRNO(ERROR_CONFIG, "palette.chars too long");
          }
        }
      }
      continue;
    }
 
    // Special handling for no-encrypt (auto-disables encrypt_enabled)
    // The TOML key is "security.no_encrypt" (from SECURITY group, no-encrypt option)
    if (strcmp(meta->toml_key, "security.no_encrypt") == 0) {
      bool no_encrypt_val = false;
      if (strcmp(value_str, "true") == 0 || strcmp(value_str, "1") == 0) {
        no_encrypt_val = true;
      } else if (strcmp(value_str, "false") == 0 || strcmp(value_str, "0") == 0) {
        no_encrypt_val = false;
      } else {
        CONFIG_WARN("Invalid no_encrypt value '%s' (expected true/false), skipping", value_str);
        if (strict) {
          SAFE_FREE(option_set_flags);
          return SET_ERRNO(ERROR_CONFIG, "Invalid no_encrypt value");
        }
        continue;
      }
 
      opts->no_encrypt = no_encrypt_val;
      if (no_encrypt_val) {
        // When no_encrypt is enabled, automatically disable encrypt_enabled
        opts->encrypt_enabled = false;
      }
      option_set_flags[i] = true;
      continue;
    }
 
    // Parse and validate value using handler
    char error_msg[BUFFER_SIZE_SMALL] = {0};
    option_parsed_value_t parsed = {0};
    asciichat_error_t parse_result = ASCIICHAT_OK;
 
    // Handle CALLBACK types using their custom parse function
    if (meta->type == OPTION_TYPE_CALLBACK) {
      if (meta->parse_fn) {
        // Use custom parse function for callbacks (e.g., port parsing)
        void *field_ptr = (char *)opts + meta->field_offset;
        char *callback_error = NULL;
        if (meta->parse_fn(value_str, field_ptr, &callback_error)) {
          // Successfully parsed - callback has written to opts directly
          if (callback_error) {
            SAFE_FREE(callback_error);
          }
          // Mark as set to continue to validation
          option_set_flags[i] = true;
          // Don't continue - fall through to validation check below
        } else {
          // Parsing failed
          CONFIG_WARN("Invalid %s value '%s': %s (skipping)", meta->toml_key, value_str,
                      callback_error ? callback_error : "parsing failed");
          if (callback_error) {
            SAFE_FREE(callback_error);
          }
          if (strict) {
            if (first_error == ASCIICHAT_OK) {
              first_error = SET_ERRNO(ERROR_CONFIG, "Invalid %s value", meta->toml_key);
            }
          }
          continue;
        }
      } else {
        // No parse function for callback type
        CONFIG_WARN("No parser for callback %s (parse_fn is NULL) (skipping)", meta->toml_key);
        continue;
      }
    } else if (meta->type == OPTION_TYPE_ACTION) {
      // Skip action types (not loaded from config)
      continue;
    } else if (g_type_handlers[meta->type].parse_validate) {
      // Use standard type handler for parsing/validation
      parse_result = g_type_handlers[meta->type].parse_validate(value_str, meta, &parsed, error_msg, sizeof(error_msg));
      if (parse_result != ASCIICHAT_OK) {
        CONFIG_WARN("Invalid %s value '%s': %s (skipping)", meta->toml_key, value_str, error_msg);
        if (strict) {
          if (first_error == ASCIICHAT_OK) {
            first_error = SET_ERRNO(ERROR_CONFIG, "Invalid %s: %s", meta->toml_key, error_msg);
          }
        }
        continue;
      }
 
      // Write value to options_t using handler
      if (g_type_handlers[meta->type].write_to_struct) {
        char error_msg_write[BUFFER_SIZE_SMALL] = {0};
        asciichat_error_t write_result =
            g_type_handlers[meta->type].write_to_struct(&parsed, meta, opts, error_msg_write, sizeof(error_msg_write));
        if (write_result != ASCIICHAT_OK) {
          CONFIG_WARN("Failed to write %s: %s (skipping)", meta->toml_key, error_msg_write);
          if (strict) {
            if (first_error == ASCIICHAT_OK) {
              first_error = write_result;
            }
          }
          continue;
        }
      }
 
      // Mark option as set
      option_set_flags[i] = true;
    } else {
      // No handler for this type
      CONFIG_WARN("No handler for %s (skipping)", meta->toml_key);
      continue;
    }
 
    // Call builder's validate function if it exists (for cross-field validation)
    if (meta->validate_fn) {
      char *validate_error = NULL;
      if (!meta->validate_fn(opts, &validate_error)) {
        CONFIG_WARN("Validation failed for %s: %s (skipping)", meta->toml_key,
                    validate_error ? validate_error : "validation failed");
        if (validate_error) {
          SAFE_FREE(validate_error);
        }
        if (strict) {
          if (first_error == ASCIICHAT_OK) {
            first_error = SET_ERRNO(ERROR_CONFIG, "Validation failed for %s", meta->toml_key);
          }
          continue;
        }
        continue;
      }
    }
 
    // Mark this option as set
    option_set_flags[i] = true;
  }
 
  // Handle special crypto.no_encrypt logic
  toml_datum_t no_encrypt = toml_seek(toptab, "crypto.no_encrypt");
  if (no_encrypt.type == TOML_BOOLEAN && no_encrypt.u.boolean) {
    opts->no_encrypt = 1;
    // Don't modify encrypt_enabled - they are independent flags
    // The conflict validation will catch if both are set
  }
 
  // Handle password warning (check both crypto and security sections)
  toml_datum_t password = toml_seek(toptab, "crypto.password");
  if (password.type == TOML_UNKNOWN) {
    password = toml_seek(toptab, "security.password");
  }
  if (password.type == TOML_STRING) {
    const char *password_str = get_toml_string_validated(password);
    if (password_str && strlen(password_str) > 0) {
      CONFIG_WARN("Password stored in config file is insecure! Use CLI --password instead.");
    }
  }
 
  SAFE_FREE(option_set_flags);
  return first_error;
}
 
asciichat_error_t config_load_and_apply(asciichat_mode_t detected_mode, const char *config_path, bool strict,
                                        options_t *opts) {
  // detected_mode is used in config_apply_schema for bitmask validation
  char *config_path_expanded = NULL;
  defer(SAFE_FREE(config_path_expanded));
 
  if (config_path) {
    // Use custom path provided
    config_path_expanded = expand_path(config_path);
    if (!config_path_expanded) {
      // If expansion fails, try using as-is (might already be absolute)
      config_path_expanded = platform_strdup(config_path);
    }
  } else {
    // Use default location with XDG support
    char *config_dir = get_config_dir();
    defer(SAFE_FREE(config_dir));
    if (config_dir) {
      size_t len = strlen(config_dir) + strlen("config.toml") + 1;
      config_path_expanded = SAFE_MALLOC(len, char *);
      if (config_path_expanded) {
        safe_snprintf(config_path_expanded, len, "%sconfig.toml", config_dir);
      }
    }
 
    // Fallback to ~/.ascii-chat/config.toml
    if (!config_path_expanded) {
      config_path_expanded = expand_path("~/.ascii-chat/config.toml");
    }
  }
 
  if (!config_path_expanded) {
    if (strict) {
      return SET_ERRNO(ERROR_CONFIG, "Failed to resolve config file path");
    }
    return ASCIICHAT_OK;
  }
 
  char *validated_config_path = NULL;
  asciichat_error_t validate_result =
      path_validate_user_path(config_path_expanded, PATH_ROLE_CONFIG_FILE, &validated_config_path);
  if (validate_result != ASCIICHAT_OK) {
    SAFE_FREE(validated_config_path);
    SAFE_FREE(config_path_expanded);
    return validate_result;
  }
  // Free the old path before reassigning (defer will free the new one)
  if (config_path_expanded != validated_config_path) {
    SAFE_FREE(config_path_expanded);
  }
  config_path_expanded = validated_config_path;
 
  // Determine display path for error messages (before any early returns)
  const char *display_path = config_path ? config_path : config_path_expanded;
 
  // Log that we're attempting to load config (before logging is initialized, use stderr)
  // Only print if terminal output is enabled (suppress with --quiet)
  if (config_path && log_get_terminal_output()) {
    log_debug("Loading configuration from: %s", display_path);
  }
 
  // Check if config file exists
  struct stat st;
  if (stat(config_path_expanded, &st) != 0) {
    if (strict) {
      return SET_ERRNO(ERROR_CONFIG, "Config file does not exist: '%s'", display_path);
    }
    // File doesn't exist, that's OK - not required (non-strict mode)
    return ASCIICHAT_OK;
  }
 
  // Verify it's a regular file
  if (!S_ISREG(st.st_mode)) {
    if (strict) {
      return SET_ERRNO(ERROR_CONFIG, "Config file exists but is not a regular file: '%s'", display_path);
    }
    CONFIG_WARN("Config file exists but is not a regular file: '%s' (skipping)", display_path);
    return ASCIICHAT_OK;
  }
 
  // Parse TOML file
  toml_result_t result = toml_parse_file_ex(config_path_expanded);
  // Ensure TOML resources are freed at ALL function exit points (defer handles cleanup)
  defer(toml_free(result));
 
  if (!result.ok) {
    // result.errmsg is an array, so check its first character
    const char *errmsg = (strlen(result.errmsg) > 0) ? result.errmsg : "Unknown parse error";
 
    if (strict) {
      // For strict mode, return detailed error message directly
      // Note: SET_ERRNO stores the message in context, but asciichat_error_string() only returns generic codes
      // So we need to format the error message ourselves here
      char error_buffer[BUFFER_SIZE_MEDIUM];
      safe_snprintf(error_buffer, sizeof(error_buffer), "Failed to parse config file '%s': %s", display_path, errmsg);
      toml_free(result); // Explicit cleanup before return (defer transformation not applied)
      return SET_ERRNO(ERROR_CONFIG, "%s", error_buffer);
    }
    CONFIG_WARN("Failed to parse config file '%s': %s (skipping)", display_path, errmsg);
    toml_free(result);   // Explicit cleanup before return (defer transformation not applied)
    return ASCIICHAT_OK; // Non-fatal error
  }
 
  // Apply configuration using schema-driven parser with bitmask validation
  asciichat_error_t schema_result = config_apply_schema(result.toptab, detected_mode, opts, strict);
 
  if (schema_result != ASCIICHAT_OK && strict) {
    toml_free(result); // Explicit cleanup before return (defer transformation not applied)
    return schema_result;
  }
  // In non-strict mode, continue even if some options failed validation
 
  CONFIG_DEBUG("Loaded configuration from %s", display_path);
 
  // Log successful config load (use stderr since logging may not be initialized yet)
  // Only print if terminal output is enabled (suppress with --quiet)
  if (log_get_terminal_output()) {
    log_debug("Loaded configuration from: %s", display_path);
  }
 
  // Update RCU system with modified options (for test compatibility)
  // In real usage, options_state_set is called later after CLI parsing
  asciichat_error_t rcu_result = options_state_set(opts);
  if (rcu_result != ASCIICHAT_OK) {
    // Non-fatal - RCU might not be initialized yet in some test scenarios
    // But log as warning so tests can see if this is the issue
    CONFIG_WARN("Failed to update RCU options state: %d (values may not be persisted)", rcu_result);
  }
 
  toml_free(result); // Explicit cleanup before return (defer transformation not applied)
  return ASCIICHAT_OK;
}
 
typedef struct {
  char *buffer;    // Dynamically allocated buffer
  size_t size;     // Current bytes used
  size_t capacity; // Total capacity
  bool overflow;   // Set if buffer overflows
} config_builder_t;
 
static bool config_builder_append(config_builder_t *builder, const char *fmt, ...) {
  if (builder->overflow) {
    return false;
  }
 
  if (builder->size >= builder->capacity) {
    builder->overflow = true;
    return false;
  }
 
  va_list args;
  va_start(args, fmt);
  int written = safe_vsnprintf(builder->buffer + builder->size, builder->capacity - builder->size, fmt, args);
  va_end(args);
 
  if (written < 0 || builder->size + written >= builder->capacity) {
    builder->overflow = true;
    return false;
  }
 
  builder->size += written;
  return true;
}
 
static bool config_key_should_be_commented(const char *toml_key) {
  if (!toml_key) {
    return false;
  }
 
  return strcmp(toml_key, "logging.log_file") == 0 || strcmp(toml_key, "security.password") == 0 ||
         strcmp(toml_key, "security.key") == 0 || strcmp(toml_key, "security.server_key") == 0 ||
         strcmp(toml_key, "security.client_keys") == 0 || strcmp(toml_key, "media.file") == 0 ||
         strcmp(toml_key, "media.url") == 0 || strcmp(toml_key, "media.yt_dlp_options") == 0 ||
         strcmp(toml_key, "network.turn_secret") == 0;
}
 
static asciichat_mode_t extract_mode_from_bitmask(option_mode_bitmask_t mode_bitmask) {
  // Check each mode bit
  if (mode_bitmask == OPTION_MODE_SERVER)
    return MODE_SERVER;
  if (mode_bitmask == OPTION_MODE_CLIENT)
    return MODE_CLIENT;
  if (mode_bitmask == OPTION_MODE_MIRROR)
    return MODE_MIRROR;
  if (mode_bitmask == OPTION_MODE_DISCOVERY_SVC)
    return MODE_DISCOVERY_SERVICE;
  if (mode_bitmask == OPTION_MODE_DISCOVERY)
    return MODE_DISCOVERY;
  // Bitmask has zero or multiple bits set
  return MODE_INVALID;
}
 
asciichat_error_t config_create_default(const char *config_path) {
  char *config_path_expanded = NULL;
 
  defer(SAFE_FREE(config_path_expanded));
 
  // Create fresh options with all OPT_*_DEFAULT values
  options_t defaults = options_t_new();
 
  // Allocate buffer for building config content (256KB should be plenty)
  const size_t BUFFER_CAPACITY = 256 * 1024;
  config_builder_t builder = {0};
  builder.buffer = SAFE_MALLOC(BUFFER_CAPACITY, char *);
  if (!builder.buffer) {
    return SET_ERRNO(ERROR_MEMORY, "Failed to allocate config buffer");
  }
  defer(SAFE_FREE(builder.buffer));
  builder.capacity = BUFFER_CAPACITY;
 
  // Build version comment in buffer
  if (!config_builder_append(&builder, "# ascii-chat configuration file\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "# Generated by ascii-chat v%d.%d.%d-%s\n", ASCII_CHAT_VERSION_MAJOR,
                             ASCII_CHAT_VERSION_MINOR, ASCII_CHAT_VERSION_PATCH, ASCII_CHAT_GIT_VERSION)) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "#\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "# All options below are commented out because some configuration options\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "# conflict with each other (e.g., --file vs --url, --loop vs --url).\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "# Uncomment only the options you need and avoid conflicting combinations.\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "#\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder,
                             "# If you upgrade ascii-chat and this version comment changes, you may need to\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "# delete and regenerate this file with: ascii-chat --config-create\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
  if (!config_builder_append(&builder, "#\n\n")) {
    return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
  }
 
  // Get all options from schema
  size_t metadata_count = 0;
  const config_option_metadata_t *metadata = config_schema_get_all(&metadata_count);
 
  // Build list of unique categories in order of first appearance
  const char *categories[16] = {0}; // Max expected categories
  size_t category_count = 0;
 
  for (size_t i = 0; i < metadata_count && category_count < 16; i++) {
    const char *category = metadata[i].category;
    if (!category) {
      continue;
    }
 
    // Check if category already in list
    bool found = false;
    for (size_t j = 0; j < category_count; j++) {
      if (categories[j] && strcmp(categories[j], category) == 0) {
        found = true;
        break;
      }
    }
 
    if (!found) {
      categories[category_count++] = category;
    }
  }
 
  // Build each section dynamically from schema
  for (size_t cat_idx = 0; cat_idx < category_count; cat_idx++) {
    const char *category = categories[cat_idx];
    if (!category) {
      continue;
    }
 
    // Get all options for this category
    size_t cat_option_count = 0;
    const config_option_metadata_t **cat_options = config_schema_get_by_category(category, &cat_option_count);
 
    if (!cat_options || cat_option_count == 0) {
      continue;
    }
 
    // Add section header
    if (!config_builder_append(&builder, "[%s]\n", category)) {
      return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
    }
 
    // Track which options we've written (to avoid duplicates)
    bool written_flags[64] = {0}; // Max options per category
 
    // Add each option in this category
    for (size_t opt_idx = 0; opt_idx < cat_option_count && opt_idx < 64; opt_idx++) {
      const config_option_metadata_t *meta = cat_options[opt_idx];
      if (!meta || !meta->toml_key) {
        continue;
      }
 
      // Skip if already written (duplicate)
      if (written_flags[opt_idx]) {
        continue;
      }
 
      // Skip if this is a duplicate of another option (check by TOML key, not field_offset)
      // Note: Multiple options can map to the same field (e.g., server_log_file, client_log_file)
      bool is_duplicate = false;
      for (size_t j = 0; j < opt_idx; j++) {
        if (cat_options[j] && cat_options[j]->toml_key && meta->toml_key &&
            strcmp(cat_options[j]->toml_key, meta->toml_key) == 0) {
          is_duplicate = true;
          break;
        }
      }
      if (is_duplicate) {
        continue;
      }
 
      // Get field pointer from default options (or mode-specific default if available)
      const char *field_ptr = ((const char *)&defaults) + meta->field_offset;
 
      // Buffer to hold mode-specific default value if needed
      char mode_default_buffer[OPTIONS_BUFF_SIZE] = {0};
      int mode_default_int = 0;
 
      // If this option has a mode_default_getter, use it to get the correct default
      if (meta->mode_default_getter) {
        asciichat_mode_t mode = extract_mode_from_bitmask(meta->mode_bitmask);
        if (mode != MODE_INVALID) {
          const void *default_value = meta->mode_default_getter(mode);
          if (default_value) {
            // Copy the default value to our buffer based on type
            if (meta->type == OPTION_TYPE_STRING || meta->type == OPTION_TYPE_CALLBACK) {
              const char *str_value = (const char *)default_value;
              SAFE_STRNCPY(mode_default_buffer, str_value, sizeof(mode_default_buffer));
              field_ptr = mode_default_buffer;
            } else if (meta->type == OPTION_TYPE_INT) {
              mode_default_int = *(const int *)default_value;
              field_ptr = (const char *)&mode_default_int;
            }
          }
        }
      }
 
      // Add description comment if available
      if (meta->description && strlen(meta->description) > 0) {
        if (!config_builder_append(&builder, "# %s\n", meta->description)) {
          return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
        }
      }
 
      // Format and add the option value using handler (commented out to avoid conflicts)
      if (g_type_handlers[meta->type].format_output) {
        char formatted_value[BUFFER_SIZE_MEDIUM] = {0};
        g_type_handlers[meta->type].format_output(field_ptr, meta->field_size, meta, formatted_value,
                                                  sizeof(formatted_value));
        const char *output_key = meta->toml_key;
        size_t category_len = strlen(category);
        if (strncmp(meta->toml_key, category, category_len) == 0 && meta->toml_key[category_len] == '.') {
          output_key = meta->toml_key + category_len + 1; // Strip "<category>."
        }
 
        if (config_key_should_be_commented(meta->toml_key)) {
          if (!config_builder_append(&builder, "# %s = %s\n", output_key, formatted_value)) {
            return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
          }
        } else {
          if (!config_builder_append(&builder, "%s = %s\n", output_key, formatted_value)) {
            return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
          }
        }
      }
 
      // Add blank line after each option
      if (!config_builder_append(&builder, "\n")) {
        return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
      }
 
      written_flags[opt_idx] = true;
    }
 
    // Add blank line between sections (but not after the last section)
    if (cat_idx < category_count - 1) {
      if (!config_builder_append(&builder, "\n")) {
        return SET_ERRNO(ERROR_CONFIG, "Config too large to fit in buffer");
      }
    }
  }
 
  // Now write the buffer to either stdout or a file
  if (config_path && strlen(config_path) > 0) {
    // User provided a filepath - write to that file with overwrite prompt
 
    // Expand and validate the path
    config_path_expanded = expand_path(config_path);
    if (!config_path_expanded) {
      config_path_expanded = platform_strdup(config_path);
    }
 
    if (!config_path_expanded) {
      return SET_ERRNO(ERROR_CONFIG, "Failed to resolve config file path");
    }
 
    char *validated_config_path = NULL;
    asciichat_error_t validate_result =
        path_validate_user_path(config_path_expanded, PATH_ROLE_CONFIG_FILE, &validated_config_path);
    if (validate_result != ASCIICHAT_OK) {
      SAFE_FREE(validated_config_path);
      SAFE_FREE(config_path_expanded);
      return validate_result;
    }
    // Free the old path before reassigning (defer will free the new one)
    if (config_path_expanded != validated_config_path) {
      SAFE_FREE(config_path_expanded);
    }
    config_path_expanded = validated_config_path;
 
    // Check if file already exists
    struct stat st;
    if (stat(config_path_expanded, &st) == 0) {
      // File exists - ask user if they want to overwrite
      log_plain("Config file already exists: %s", config_path_expanded);
 
      bool overwrite = platform_prompt_yes_no("Overwrite", false); // Default to No
      if (!overwrite) {
        log_plain("Config file creation cancelled.");
        return SET_ERRNO(ERROR_CONFIG, "User cancelled overwrite");
      }
 
      log_plain("Overwriting existing config file...");
    }
 
    // Create directory if needed
    char *dir_path = platform_strdup(config_path_expanded);
    if (!dir_path) {
      return SET_ERRNO(ERROR_MEMORY, "Failed to allocate memory for directory path");
    }
    defer(SAFE_FREE(dir_path));
 
    // Find the last path separator
    char *last_sep = strrchr(dir_path, PATH_DELIM);
 
    if (last_sep) {
      *last_sep = '\0';
      // Create directory recursively
      asciichat_error_t mkdir_result = platform_mkdir_recursive(dir_path, DIR_PERM_PRIVATE);
      if (mkdir_result != ASCIICHAT_OK) {
        return mkdir_result;
      }
    }
 
    // Open file for writing
    FILE *output_file = platform_fopen(config_path_expanded, "w");
    if (!output_file) {
      return SET_ERRNO_SYS(ERROR_CONFIG, "Failed to open config file for writing: %s", config_path_expanded);
    }
    defer(SAFE_FCLOSE(output_file));
 
    // Write buffer to file
    size_t written = fwrite(builder.buffer, 1, builder.size, output_file);
    if (written != builder.size) {
      return SET_ERRNO_SYS(ERROR_CONFIG, "Failed to write config to file: %s", config_path_expanded);
    }
  } else {
    // No filepath provided - write buffer to stdout with automatic retry on transient errors
    (void)platform_write_all(STDOUT_FILENO, builder.buffer, builder.size);
    // Flush C stdio buffer and terminal to ensure piped output is written immediately
    (void)fflush(stdout);
    (void)terminal_flush(STDOUT_FILENO);
  }
 
  return ASCIICHAT_OK;
}
 
asciichat_error_t config_load_system_and_user(asciichat_mode_t detected_mode, bool strict, options_t *opts) {
  // Use platform abstraction to find all config.toml files across standard locations
  config_file_list_t config_files = {0};
  asciichat_error_t search_result = platform_find_config_file("config.toml", &config_files);
  defer(config_file_list_destroy(&config_files));
 
  if (search_result != ASCIICHAT_OK) {
    CONFIG_DEBUG("Failed to search for config files: %d", search_result);
    config_file_list_destroy(&config_files);
    return search_result;
  }
 
  // Cascade load: Load all found configs in reverse order (lowest priority first)
  // This allows higher-priority configs to override lower-priority values.
  // Example: System configs load first, then user configs override them.
 
  asciichat_error_t result = ASCIICHAT_OK;
  for (size_t i = config_files.count; i > 0; i--) {
    const config_file_result_t *file = &config_files.files[i - 1];
 
    // Determine strictness based on whether this is a system or user config
    // System configs are non-strict (values can be missing, errors are non-fatal)
    // User config is strict or non-strict based on parameter
    bool is_user_config = !file->is_system_config;
    bool file_strict = is_user_config ? strict : false;
 
    CONFIG_DEBUG("Loading config from %s (system=%s, strict=%s)", file->path, file->is_system_config ? "yes" : "no",
                 file_strict ? "true" : "false");
 
    asciichat_error_t load_result = config_load_and_apply(detected_mode, file->path, file_strict, opts);
 
    if (load_result != ASCIICHAT_OK) {
      if (file_strict) {
        // Strict mode: errors are fatal
        CONFIG_DEBUG("Strict config loading failed for %s", file->path);
        result = load_result;
      } else {
        // Non-strict mode: errors are non-fatal, just log and continue
        CONFIG_DEBUG("Non-strict config loading warning for %s: %d (continuing)", file->path, load_result);
        CLEAR_ERRNO(); // Clear error context for next file
      }
    }
  }
 
  config_file_list_destroy(&config_files);
  return result;
}